Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tsconfig/node-lts-strictest should set "moduleResolution" to "node16" (instead of "node") #204

Open
andreashuber69 opened this issue Jul 11, 2023 · 3 comments

Comments

@andreashuber69
Copy link

andreashuber69 commented Jul 11, 2023

@tsconfig/node-lts-strictest currently sets "moduleResolution": "node" which does not make sense for node 12 and later, as documented under https://www.typescriptlang.org/tsconfig#moduleResolution. "moduleResolution": "node16" would be correct for an lts config.

P.S. Yes, @tsconfig/node-lts-strictest is deprecated and for good reasons. However, projects using eslint-plugin-import are unable to extend from an array of bases (see import-js/eslint-plugin-import#2751), which is why these projects are currently stuck with @tsconfig/node-lts-strictest. It would therefore be nice if this config could be maintained until extending from arrays of bases is supported by the wider ecosystem.

@andreashuber69 andreashuber69 changed the title @tsconfig/node-lts-strictest should set "moduleResolution" to "node16" (instead of node) @tsconfig/node-lts-strictest should set "moduleResolution" to "node16" (instead of "node") Jul 11, 2023
@orta
Copy link
Member

orta commented Jul 15, 2023

I respect it, but this is just one of many side-projects I maintain in my free time and I want to be maintaining things which makes sense to be deprecated as little as possible

@nemchik
Copy link

nemchik commented Aug 25, 2023

Potentially relevant https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/#module-and-moduleresolution-must-match-under-recent-node-js-settings
May affect other bases as well.

@orta
Copy link
Member

orta commented Aug 25, 2023

Pretty sure all the non-deprecated tsconfigs conform to this 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants