Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty strings are treated as URLs #279

Open
ImRodry opened this issue Mar 15, 2021 · 2 comments · May be fixed by #307
Open

Empty strings are treated as URLs #279

ImRodry opened this issue Mar 15, 2021 · 2 comments · May be fixed by #307

Comments

@ImRodry
Copy link

ImRodry commented Mar 15, 2021

If your JSON page has an empty string ("", no spaces) and you have clickableUrls set to true, the extension will treat them as URLs and lead you to an about:blank page on click. I've tested this across websites and it happened to be the case in all situations so far.
@turkerdev
Copy link

Here is the example
https://api.github.com/repos/tulios/json-viewer
"gravatar_id": "",

@ImRodry
Copy link
Author

ImRodry commented Apr 15, 2021

Thank you @bajosiaa!

@ivanistuk ivanistuk linked a pull request Oct 28, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty strings being treated as URLs ivanistuk/json-viewer
2 participants
@ImRodry @turkerdev