New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `Insn::ParseSchema` to use same connection to run nested query #1096

Open

pereman2 opened this issue Mar 5, 2025 · 1 comment

Collaborator

pereman2 commented Mar 5, 2025

There are two ways to fix it:

Make the nested query run on the same connection instead of creating a new one.
Not run the query and simply update schema directly which should be fine.

I think we should probably go for 1. because it is what SQLite does, but if someone provides a simple solution for 2. then we are okay.

Collaborator

penberg commented Mar 5, 2025

Note that we use the same connection but fail to reuse the same TX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment