Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Sales and Support call counter #287

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added Sales and Support call counter #287

wants to merge 5 commits into from

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Sep 11, 2024 •
edited
Loading

Close #131

Technical Description

created

sales_call_count and support_call_count

which we iterate in sales_call and support_call view functions

Testing

  • setup tc2
  • setup tc.com
  • setup pd
  • create custom field on Org (with hermes field names set), create a data field in pd ...
  • signup
  • book sales call
  • book support call
  • check counts
  • book more calls
  • check counts go up

implementation

  1. run aerich upgrade
  2. create custom fields sales_call_count and support_call_count on hermes for both deal and company
  3. create the same custom fields for deal and org in pd, be sure to update the pd API key

image
image

  1. run python patch.py update_call_counts this will update the call counts on the company model and then push those changes to pd

image
image

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (63afdab) to head (b0ea170).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   90.07%   90.15%   +0.07%     
==========================================
  Files          29       29              
  Lines        1884     1889       +5     
  Branches      296      296              
==========================================
+ Hits         1697     1703       +6     
  Misses        135      135              
+ Partials       52       51       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 24, 2024 •
edited
Loading

  • load up all systems locally and test

@PrenSJ2 PrenSJ2 self-assigned this Sep 24, 2024
@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Oct 10, 2024

@HenryTraill all tested locally and works, i am confident to merge and deploy this too

@PrenSJ2 PrenSJ2 assigned HenryTraill and unassigned PrenSJ2 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HenryTraill HenryTraill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Know how many Sales and Support Calls are booked
3 participants
@PrenSJ2 @codecov-commenter @HenryTraill