Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the 'Admin' data at bottom of calendar meeting template #288

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Improve the 'Admin' data at bottom of calendar meeting template #288

merged 6 commits into from
Oct 14, 2024

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Sep 12, 2024 •
edited
Loading

Close #247

Close #261

Technical Description

added more vars to the MEETING.TYPE_SALES

company name
email
phone
estimated montly income
country
also pass the pipedrive url if the pd_org_id exists

Screenshots

before
image

after
image

Inorder to property test this, we would need to create a more accurate mock of the gcal

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 12, 2024 •
edited
Loading

  • Need to test on work laptop

@PrenSJ2 PrenSJ2 changed the title Improve the 'Admin' Data in Gcal MEETING TEMPLATE Improve the 'Admin' data at bottom of calendar meeting template Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.93%. Comparing base (63afdab) to head (a56fb3f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/callbooker/_booking.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   90.07%   89.93%   -0.15%     
==========================================
  Files          29       29              
  Lines        1884     1887       +3     
  Branches      296      298       +2     
==========================================
  Hits         1697     1697              
- Misses        135      136       +1     
- Partials       52       54       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 13, 2024 •
edited
Loading

  • Would need to mock the create_cal_event to check the meeting description
  • also need to test live with systems running locally

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Oct 9, 2024

  • this works and could be merged, what do you think @HenryTraill

@tomhamiltonstubber tomhamiltonstubber merged commit ed025f1 into main Oct 14, 2024
2 checks passed
@tomhamiltonstubber tomhamiltonstubber deleted the improve-gcal-template branch October 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HenryTraill HenryTraill

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@PrenSJ2 @codecov-commenter @tomhamiltonstubber @HenryTraill