Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sales Callbooker try to match by phone #285

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Sales Callbooker try to match by phone #285

merged 3 commits into from
Oct 14, 2024

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Sep 11, 2024 •
edited
Loading

Close #248

Technical Description

In get_or_create_contact_company add a condition to try and find a match by phone number

currently we try by id
then email
then exact name match

now we then try by phone

Testing

  • setup tc.com
  • setup TC2
  • book a call
  • a new company and contact are created in hermes and pd
  • clear site data
  • book another call with all different details except the same phone number
  • login to hermes,
  • see no new contact and company have been created
  • go into pd and see that no new deal, contact and company have been made
  • but see on the deal another activity (call) has been created

image

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.98%. Comparing base (63afdab) to head (b570fa3).

Files with missing lines Patch % Lines
app/callbooker/_process.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   90.07%   89.98%   -0.10%     
==========================================
  Files          29       29              
  Lines        1884     1887       +3     
  Branches      296      298       +2     
==========================================
+ Hits         1697     1698       +1     
- Misses        135      136       +1     
- Partials       52       53       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 11, 2024

cant get tests to work on my mac, so will check this out on my lunch break

HenryTraill
HenryTraill approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@HenryTraill HenryTraill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Oct 9, 2024

I have now tested this, and am happy to merge if you are @HenryTraill

@PrenSJ2 PrenSJ2 assigned HenryTraill and unassigned PrenSJ2 Oct 9, 2024
@tomhamiltonstubber tomhamiltonstubber merged commit 1b2180b into main Oct 14, 2024
2 checks passed
@tomhamiltonstubber tomhamiltonstubber deleted the check-sale-call-by-phone branch October 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryTraill HenryTraill HenryTraill approved these changes

Assignees

@HenryTraill HenryTraill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Match companies on field such as email and phone number rather than just tc2_cligency id
4 participants
@PrenSJ2 @codecov-commenter @HenryTraill @tomhamiltonstubber