Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the 'Admin' data at bottom of calendar meeting template #288

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve the 'Admin' data at bottom of calendar meeting template #288

wants to merge 5 commits into from

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Sep 12, 2024

Close #247

Close #261

Technical Description

added more vars to the MEETING.TYPE_SALES

company name
email
phone
estimated montly income
country

also pass the pipedrive url if the pd_org_id exists

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 12, 2024 •
edited
Loading

  • Need to test on work laptop

@PrenSJ2 PrenSJ2 changed the title Improve the 'Admin' Data in Gcal MEETING TEMPLATE Improve the 'Admin' data at bottom of calendar meeting template Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (63afdab) to head (8b7a1a8).

Files with missing lines Patch % Lines
app/callbooker/_booking.py 46.42% 4 Missing and 11 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   90.07%   89.41%   -0.66%     
==========================================
  Files          29       29              
  Lines        1884     1909      +25     
  Branches      296      309      +13     
==========================================
+ Hits         1697     1707      +10     
- Misses        135      139       +4     
- Partials       52       63      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 13, 2024 •
edited
Loading

Would need to mock the create_cal_event

in order to check the meeting description

also need to test live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PrenSJ2 @codecov-commenter