-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Sass Modules (dart-sass) #363
Comments
Right now we still do support |
Using / for division is deprecated and will be removed in Dart Sass 2.0.0. Here is a migrated version
|
I do support @kimchristiansen! I have some warnings in my project like:
All these warnings are related to rfs npm package (version is 9.0.6), and a warning trace logs for each file where rfs mixin is used. |
Same support here! |
There is any issue in the fixed version. for some reason the text is still growing on 1200px + https://raw.githubusercontent.com/twbs/rfs/master/.github/rfs-graph.svg as you can see on the overview page from this repository, it should stop growing on 1200px + |
@kimchristiansen how to use your updated .scss because npm I always run and removed your .scss? |
I just realized that thanks to the new css function clamp() you don't need this mixin anymore. just google css clamp () font-size. |
FYI: min and clamp are discussed here: #110 |
@kimchristiansen that is great! but why not clamp() like the person from the latest comment? |
Clamp only defines a preferred value, a min value and a max value, but not at which viewport width these values are reached. That is exactly what rfs does for you. |
Because of this image from the readme of this repository, I honestly always thought it was a bug that the font size kept growing and growing even after 1200px: https://raw.githubusercontent.com/twbs/rfs/main/.github/rfs-graph.svg?sanitize=true But if this is a desired effect... sure then clamp alone doesn't help. exactly this circumstance disturbs a little, in our current project where we have a fixed max content width :) |
@kimchristiansen Can you help me with my query? |
I am not the maintainer of this library. But you can copy the code from above and insert it directly in your scss files. |
@kimchristiansen Why don't you create a pull request for this fix? |
@kimchristiansen is there a way to tell rfs that he should not grow up anymore after 1200px? if i understand it correctly it should do this automaticly: https://github.com/twbs/rfs#breakpoint-in-px-em-or-rem but it dont. |
@SvenBudak Since your question is not related to this issue, I would ask you to look at the documentation or the examples. |
@kimchristiansen i understand now why it is not working on my project... it is because i use it like this: |
Thank you for creating the ported version - I've tested and it works well in Dart Sass. If anyone else running into this issue just copy and paste #363 (comment) into your project. |
Some functions in the scss files are deprecated and will be removed next Year.
So dont use lib-sass anymore and change to dart-sass.
https://sass-lang.com/blog/libsass-is-deprecated
Usefull Link:
https://sass-lang.com/documentation/at-rules
The text was updated successfully, but these errors were encountered: