You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ActivityTargetsInlinceCell has a hard re-render caused by the RecordShowContainer.
This is caused by subscriptions made at all levels with grouping hooks which is a pattern we try to avoid.
This is a high priority refactor because right now anything that is inside a RecordShowContainer will have a hard re-render for any field change.
This refactor would also help for the next iteration with modular show container could be hard to make with the current state.
Technical inputs
Here is a break-down of this refactor :
Refactor RecordShowPage and useRecordShowPage hook
Create ObjectRecordContext ⇒ name + id OR try re-using an existing context that might fit
Refactor RecordShowContainer and useRecordShowData
Refactor ShowPageSubContainer ⇒ remove object-record from ui/layout
Rename to RecordShowPageSubContainer
Refactor CardComponent should take its object record from context
Refactor FieldsCard
Refactor ActivityTargetsInlineCell
Get activity from record store + object record context
Remove useEffects and set directly selected records in
All the refactor should also take care of the following :
Removing any props that can be replaced by a call to useContext (most probably 100% can be replaced in this refactor, props drill-down should be avoided and here it is most of the time just object name and record id)
Remove any "grouping" hook : split in multiple unit hooks, call states directly where they are needed, remove unnecessary useEffect state synchronization logic, move effects to Effect components
The text was updated successfully, but these errors were encountered:
Scope & Context
ActivityTargetsInlinceCell has a hard re-render caused by the RecordShowContainer.
This is caused by subscriptions made at all levels with grouping hooks which is a pattern we try to avoid.
This is a high priority refactor because right now anything that is inside a RecordShowContainer will have a hard re-render for any field change.
This refactor would also help for the next iteration with modular show container could be hard to make with the current state.
Technical inputs
Here is a break-down of this refactor :
All the refactor should also take care of the following :
The text was updated successfully, but these errors were encountered: