[VBLOCKS-4107] Fix null publisher on destroy (#317)

* fix: reorder device destroy operations

* chore: unit tests

* docs: changelog entry

Author: mhuynh5757

CHANGELOG.md

@@ -13,6 +13,11 @@ Changes
 
 - Added an API for testing `PreflightTest` in realms other than prod. Users can now pass `chunderw` and `eventgw` values within the options object when constructing a `PreflightTest`. Note that these new options are meant for internal testing by Twilio employees only, and should not be used otherwise.
 
+Bug Fixes
+---------
+
+- Addressed an issue where the `publisher` would be `null` upon destruction of an `AudioProcessorObserver`.
+
 2.12.3 (December 3, 2024)
 =========================
 

lib/twilio/device.ts

@@ -646,9 +646,9 @@ class Device extends EventEmitter {
     this._stopRegistrationTimer();
 
     this._destroyStream();
-    this._destroyPublisher();
     this._destroyAudioHelper();
     this._audioProcessorEventObserver?.destroy();
+    this._destroyPublisher();
 
     if (this._networkInformation && typeof this._networkInformation.removeEventListener === 'function') {
       this._networkInformation.removeEventListener('change', this._publishNetworkChange);

tests/unit/device.ts

@@ -475,6 +475,15 @@ describe('Device', function() {
           sinon.assert.calledOnce(stub);
         });
 
+        it('should destroy the publisher after the audioProcessorEventObserver', () => {
+          const observerStub =
+            (device['_audioProcessorEventObserver']!.destroy = sinon.stub());
+          const publisherStub =
+            (device['_destroyPublisher'] = sinon.stub());
+          device.destroy();
+          assert(observerStub.calledBefore(publisherStub));
+        });
+
         it('should stop sending registrations', () => {
           pstream.register.resetHistory();