You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I actually had another review idea for this file before it got merged, not critical at all just wanted to jot it down in a ticket. The pathlib is the preferred version of the os.path module, I would drop os module if it is only used for path stuff, since Path is loaded you should be able to actually read the QC csv using Path as a converter function like:
I actually had another review idea for this file before it got merged, not critical at all just wanted to jot it down in a ticket. The
pathlib
is the preferred version of theos.path
module, I would dropos
module if it is only used for path stuff, sincePath
is loaded you should be able to actually read the QC csv usingPath
as a converter function like:Implied here is that the columns have names instead of leaving them unnamed, which would also improve clarity.
The text was updated successfully, but these errors were encountered: