Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement idea for QC script #12

Open
kyleredilla opened this issue Jan 25, 2024 · 0 comments
Open

Minor enhancement idea for QC script #12

kyleredilla opened this issue Jan 25, 2024 · 0 comments

Comments

@kyleredilla
Copy link
Contributor

I actually had another review idea for this file before it got merged, not critical at all just wanted to jot it down in a ticket. The pathlib is the preferred version of the os.path module, I would drop os module if it is only used for path stuff, since Path is loaded you should be able to actually read the QC csv using Path as a converter function like:

pd.read_csv(qc_file, converters={"data_file": Path, "slurm_file": Path})

Implied here is that the columns have names instead of leaving them unnamed, which would also improve clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant