Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check response status for 422 in the EDS retryable data fetch function, rather than the response itself #525

Open
charparr opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@charparr
Copy link
Member

In this function https://github.com/ua-snap/data-api/blob/7a11164ae1dec5d561a8c98828fd752d1d8b8d3b/routes/eds.py#L34C1-L52C1

the line with and (response.status != 400 and response.status != 404 and response != 422) should actually have response.status != 422 as the last term.

As written, the consequence is that we may not be sleeping before retrying the request.

@charparr charparr added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant