PrivacyPage: add clear recently used button (#294)

Author: Feichtmeier

lib/l10n/app_de.arb

@@ -62,12 +62,12 @@
   "houseKeepingRecentFilesRememberAction": "Dateichronik",
   "houseKeepingRecentFilesRememberForeverAction": "Dateichronik für immer behalten",
   "houseKeepingRecentFilesDaysAction": "Zeitraum der Dateichronik",
+  "houseKeepingRecentFilesClearAction": "Dateichronik bereinigen",
   "houseKeepingTempTrashHeadline": "Papierkorb und temporäre Datelen",
   "houseKeepingTempTrashDescription": "Der Papierkorb sowie temporare Dateien können persönliche und sensible Informationen enthalten. Eine automatische Löschung kann dem Erhalt Ihrer Privatsphäre dienen.",
   "houseKeepingTrashAutoRemoveAction": "Automatisch den Papierkorb leeren",
   "houseKeepingTempAutoRemoveAction": "Automatisch temporäre Dateien löschen",
   "houseKeepingTempTrashAutoDeleteDays": "Zeitraum für automatisches Löschen",
-  "houseKeepingTempTrashActionLabel": "Bereinigen",
   "houseKeepingEmptyTrash": "Papierkorb leeren",
   "houseKeepingRemoveTempFiles": "Temporäre Dateien löschen",
   "privacyPageTitle": "Datenschutz",

lib/l10n/app_en.arb

@@ -62,12 +62,12 @@
   "houseKeepingRecentFilesRememberAction": "File history",
   "houseKeepingRecentFilesRememberForeverAction": "Keep file history forever",
   "houseKeepingRecentFilesDaysAction": "Period of file history",
+  "houseKeepingRecentFilesClearAction": "Delete recent file history",
   "houseKeepingTempTrashHeadline": "Recycle bin and temporary files",
   "houseKeepingTempTrashDescription": "The recycle bin and temporary files can contain personal and sensitive information. Automatic deletion can serve to preserve your privacy.",
   "houseKeepingTrashAutoRemoveAction": "Automatically empty the recycle bin",
   "houseKeepingTempAutoRemoveAction": "Automatically delete temporary files",
   "houseKeepingTempTrashAutoDeleteDays": "Period for automatic deletion",
-  "houseKeepingTempTrashActionLabel": "Clean up",
   "houseKeepingEmptyTrash": "Empty trash",
   "houseKeepingRemoveTempFiles": "Delete temporary files",
   "privacyPageTitle": "Privacy",

lib/services/house_keeping_service.dart

@@ -1,11 +1,13 @@
 import 'dart:async';
+import 'dart:io';
 
 import 'package:dbus/dbus.dart';
 
-const kHouseKeepingInterface = 'org.gnome.SettingsDaemon.Housekeeping';
-const kHouseKeepingPath = '/org/gnome/SettingsDaemon/Housekeeping';
-const kEmptyTrashMethodName = 'EmptyTrash';
-const kRemoveTempFiles = 'RemoveTempFiles';
+const _kHouseKeepingInterface = 'org.gnome.SettingsDaemon.Housekeeping';
+const _kHouseKeepingPath = '/org/gnome/SettingsDaemon/Housekeeping';
+const _kEmptyTrashMethodName = 'EmptyTrash';
+const _kRemoveTempFiles = 'RemoveTempFiles';
+const _kRecentlyUsedFilePathSuffix = '/.local/share/recently-used.xbel';
 
 class HouseKeepingService {
   final DBusRemoteObject _object;
@@ -15,8 +17,8 @@ class HouseKeepingService {
   static DBusRemoteObject _createObject() {
     return DBusRemoteObject(
       DBusClient.session(),
-      name: kHouseKeepingInterface,
-      path: DBusObjectPath(kHouseKeepingPath),
+      name: _kHouseKeepingInterface,
+      path: DBusObjectPath(_kHouseKeepingPath),
     );
   }
 
@@ -27,14 +29,27 @@ class HouseKeepingService {
   void emptyTrash() => _object.emptyTrash();
 
   void removeTempFiles() => _object.removeTempFiles();
+
+  void clearRecentlyUsed() {
+    final String? path =
+        Platform.environment['HOME']! + _kRecentlyUsedFilePathSuffix;
+    if (Platform.environment['HOME'] == null || path == null) return;
+    var file = File(path);
+    var sink = file.openWrite();
+    const cleanContent = '''<?xml version="1.0" encoding="UTF-8"?>
+                            <xbel version="1.0" xmlns:bookmark="http://www.freedesktop.org/standards/desktop-bookmarks" xmlns:mime="http://www.freedesktop.org/standards/shared-mime-info">
+                            </xbel>''';
+    sink.write(cleanContent);
+    sink.close();
+  }
 }
 
 extension _HouseKeepingObject on DBusRemoteObject {
   Future<DBusMethodSuccessResponse> emptyTrash() {
-    return callMethod(kHouseKeepingInterface, kEmptyTrashMethodName, []);
+    return callMethod(_kHouseKeepingInterface, _kEmptyTrashMethodName, []);
   }
 
   Future<DBusMethodSuccessResponse> removeTempFiles() {
-    return callMethod(kHouseKeepingInterface, kRemoveTempFiles, []);
+    return callMethod(_kHouseKeepingInterface, _kRemoveTempFiles, []);
   }
 }

lib/view/pages/privacy/house_keeping_page.dart

@@ -62,7 +62,24 @@ class HouseKeepingPage extends StatelessWidget {
                     : model.recentFilesMaxAge?.toDouble(),
                 min: -1,
                 max: 30,
-                onChanged: (value) => model.recentFilesMaxAge = value.toInt())
+                onChanged: (value) => model.recentFilesMaxAge = value.toInt()),
+          YaruRow(
+              trailingWidget:
+                  Text(context.l10n.houseKeepingRecentFilesClearAction),
+              actionWidget: _TrashButton(
+                  onPressed: () => showDialog(
+                        context: context,
+                        builder: (context) => _ConfirmationDialog(
+                          title:
+                              context.l10n.houseKeepingRecentFilesClearAction,
+                          iconData: YaruIcons.clock,
+                          onConfirm: () {
+                            model.clearRecentlyUsed();
+                            Navigator.of(context).pop();
+                          },
+                        ),
+                      )),
+              enabled: true)
         ],
       ),
       YaruSection(
@@ -98,50 +115,36 @@ class HouseKeepingPage extends StatelessWidget {
                 min: 0,
                 max: 30,
                 onChanged: (value) => model.oldFilesAge = value.toInt()),
-          SizedBox(
-            width: kDefaultWidth,
-            child: Row(
-              children: [
-                Expanded(
-                  child: OutlinedButton(
-                      onPressed: () => showDialog(
-                            context: context,
-                            builder: (context) => _ConfirmationDialog(
-                              title: context.l10n.houseKeepingEmptyTrash,
-                              iconData: YaruIcons.trash_full,
-                              onConfirm: () {
-                                model.emptyTrash();
-                                Navigator.of(context).pop();
-                              },
-                            ),
-                          ),
-                      child: Text(context.l10n.houseKeepingEmptyTrash,
-                          style:
-                              TextStyle(color: Theme.of(context).errorColor))),
-                ),
-                const SizedBox(
-                  width: 10,
-                ),
-                Expanded(
-                  child: OutlinedButton(
-                      onPressed: () => showDialog(
-                            context: context,
-                            builder: (context) => _ConfirmationDialog(
-                              title: context.l10n.houseKeepingRemoveTempFiles,
-                              iconData: YaruIcons.document,
-                              onConfirm: () {
-                                model.removeTempFiles();
-                                Navigator.of(context).pop();
-                              },
-                            ),
-                          ),
-                      child: Text(context.l10n.houseKeepingRemoveTempFiles,
-                          style:
-                              TextStyle(color: Theme.of(context).errorColor))),
-                ),
-              ],
-            ),
-          ),
+          YaruRow(
+              trailingWidget: Text(context.l10n.houseKeepingEmptyTrash),
+              actionWidget: _TrashButton(
+                  onPressed: () => showDialog(
+                        context: context,
+                        builder: (context) => _ConfirmationDialog(
+                          title: context.l10n.houseKeepingEmptyTrash,
+                          iconData: YaruIcons.trash_full,
+                          onConfirm: () {
+                            model.emptyTrash();
+                            Navigator.of(context).pop();
+                          },
+                        ),
+                      )),
+              enabled: true),
+          YaruRow(
+              trailingWidget: Text(context.l10n.houseKeepingRemoveTempFiles),
+              actionWidget: _TrashButton(
+                  onPressed: () => showDialog(
+                        context: context,
+                        builder: (context) => _ConfirmationDialog(
+                          title: context.l10n.houseKeepingRemoveTempFiles,
+                          iconData: YaruIcons.document,
+                          onConfirm: () {
+                            model.removeTempFiles();
+                            Navigator.of(context).pop();
+                          },
+                        ),
+                      )),
+              enabled: true),
         ],
       ),
     ]);
@@ -237,3 +240,22 @@ class _ConfirmationDialogState extends State<_ConfirmationDialog>
     );
   }
 }
+
+class _TrashButton extends StatelessWidget {
+  const _TrashButton({Key? key, required this.onPressed}) : super(key: key);
+
+  final void Function()? onPressed;
+
+  @override
+  Widget build(BuildContext context) {
+    return SizedBox(
+      height: 40,
+      width: 40,
+      child: OutlinedButton(
+        style: OutlinedButton.styleFrom(padding: const EdgeInsets.all(0)),
+        onPressed: onPressed,
+        child: Icon(YaruIcons.trash, color: Theme.of(context).errorColor),
+      ),
+    );
+  }
+}

lib/view/pages/privacy/privacy_model.dart

@@ -71,4 +71,6 @@ class PrivacyModel extends SafeChangeNotifier {
   void emptyTrash() => _houseKeepingService.emptyTrash();
 
   void removeTempFiles() => _houseKeepingService.removeTempFiles();
+
+  void clearRecentlyUsed() => _houseKeepingService.clearRecentlyUsed();
 }