Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible ANSI color set #75

Open
adamgulde opened this issue Jan 29, 2025 · 2 comments · May be fixed by #119
Open

Compatible ANSI color set #75

adamgulde opened this issue Jan 29, 2025 · 2 comments · May be fixed by #119
Assignees
Labels
bug Something isn't working correctly or something crashes the program documentation Improvements or additions to documentation easy Good for newcomers

Comments

@adamgulde
Copy link
Collaborator

adamgulde commented Jan 29, 2025

This issue is easier than it sounds. Don't get scared by the title. Plus, it'll make all your terminal applications from now on much cooler.

For terminals with reduced color capability, we need to add a basic color set that looks hopefully decent. Review https://en.wikipedia.org/wiki/ANSI_escape_code, specifically the section on 8-bit. The color set you implement should ONLY choose from "Standard Colors" and "High-intensity colors" because I think those are the bare minimum which will be compatible with all terminals.

The relevant TODO is in style.py in the COLORS class. It is important for you to override either this class entirely or the instance variables of this class with a compatible color set. Additionally, if you can add a debug argument (-arg) to player.py and banker.py which tells the computer to use the compatible color set, that would be great.

HAVING SAID THAT, if you can test and document as many colors as possible (perhaps using a colortest() function... in style.py...), that would be an excellent, robust addition to the project.

@adamgulde adamgulde added bug Something isn't working correctly or something crashes the program documentation Improvements or additions to documentation easy Good for newcomers labels Jan 29, 2025
@mjtady
Copy link

mjtady commented Jan 29, 2025

Hey, was wondering if I could take this?

@adamgulde
Copy link
Collaborator Author

@mjtady Update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly or something crashes the program documentation Improvements or additions to documentation easy Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants