Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification on status change. #23

Open
gugod opened this issue Mar 9, 2018 · 0 comments
Open

Notification on status change. #23

gugod opened this issue Mar 9, 2018 · 0 comments

Comments

@gugod
Copy link
Collaborator

gugod commented Mar 9, 2018

I wish to be notified only when status is changed. For example, consider this build history:

  1. Success
  2. Success
  3. Success
  4. Fail
  5. Fail
  6. Success
  7. Success

The notification should sent at build number 4 (Success -> Fail) and number 6 (Fail -> Success).

Besides this, with the current implementation, each notifier decides the timing of notification on their own, commonly with these attributes:

  • ignore_success
  • ignore_skip

This leads to some code duplication in each notifier module.

This new logic of "reporting on status change" can obviously be added to all notification mdules but that'll just make the code duplication even worse. It is perhaps better to add a role that decides when to notify or not.

@gugod gugod changed the title Reporting on status change. Notification on status change. Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant