Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Customtypes2 for OPC UA 1.04 (Type Dict) #192

Closed
wants to merge 4 commits into from
Closed

WIP: Customtypes2 for OPC UA 1.04 (Type Dict) #192

wants to merge 4 commits into from

Conversation

wlkrm
Copy link
Contributor

@wlkrm wlkrm commented Jun 13, 2022

No description provided.

@wlkrm wlkrm changed the title Customtypes2 WIP: Customtypes2 Jun 13, 2022
@GoetzGoerisch
Copy link
Member

@wlkrm is this something we can get merged?

@wlkrm
Copy link
Contributor Author

wlkrm commented Jul 28, 2022

No, I suggested @karstenroethig to finish the PR, to avoid manual integration of custom datatypes in the future. Currently I have no time to finish it.

@wlkrm wlkrm force-pushed the development branch 5 times, most recently from 91ca9f0 to 834b1c6 Compare July 29, 2022 14:22
@Kantiran91 Kantiran91 mentioned this pull request Jan 10, 2023
Closed
@DasbachVDMA DasbachVDMA added this to the HMI 2023 milestone Jan 10, 2023
@DasbachVDMA DasbachVDMA added the question Further information is requested label Jan 10, 2023
@Kantiran91 Kantiran91 removed the question Further information is requested label Jan 30, 2023
@Kantiran91 Kantiran91 changed the title WIP: Customtypes2 WIP: Customtypes2 for OPC UA 1.04 Jan 30, 2023
@Kantiran91 Kantiran91 changed the title WIP: Customtypes2 for OPC UA 1.04 WIP: Customtypes2 for OPC UA 1.04 (Type Dict) Jan 30, 2023
@Kantiran91 Kantiran91 added the bug Something isn't working label Jan 30, 2023
@wlkrm
Copy link
Contributor Author

wlkrm commented Jan 30, 2023

I just remembered the issue: the data hub is providing the wrong namespace index via the TypeDictionary. It should be working fine with e.g. the SampleServer. Implementation based on Data typeDefinition should still be added, as TypeDictionary is deprecated in 1.05

@GoetzGoerisch GoetzGoerisch mentioned this pull request Mar 3, 2023
Open
@GoetzGoerisch GoetzGoerisch linked an issue Mar 8, 2023 that may be closed by this pull request
[IJT] Extension Object - ResultManagement #361
Open
@Kantiran91 Kantiran91 mentioned this pull request Mar 10, 2023
Closed
@Kantiran91
Copy link
Member

@wlkrm @GoetzGoerisch Should we switch to customtypes2-rebased for this feature?

@GoetzGoerisch
Copy link
Member

I don't recall in what context the -rebase branch was created. I would you with this branch.
But need to resolve the merge conflicts.

@mdornaus
Copy link
Contributor

Created new branch Type Dictionary with some fixes. Basically tested with Fluid sample server.

@mdornaus
Copy link
Contributor

mdornaus commented May 2, 2023

This pull-request is proceeded in the TypeDictionary branch. Please Merge from there.

@mdornaus mdornaus closed this May 2, 2023
@wlkrm wlkrm deleted the customtypes2 branch May 2, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdornaus mdornaus

Labels
bug Something isn't working
Projects
None yet
Milestone
HMI 2023
Development

Successfully merging this pull request may close these issues.

[IJT] Extension Object - ResultManagement
6 participants
@wlkrm @GoetzGoerisch @Kantiran91 @mdornaus @karstenroethig @DasbachVDMA