Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readers read twice in Dataset classes #158

Open
yreynaud opened this issue Apr 18, 2023 · 0 comments
Open

Readers read twice in Dataset classes #158

yreynaud opened this issue Apr 18, 2023 · 0 comments

Comments

@yreynaud
Copy link
Collaborator

yreynaud commented Apr 18, 2023

I noticed that when we give a meta object as input of a sar dataset object, the reader is read twice. It is unnecessary to read two times same data whereas it has already been done.
I tried to remove the use of BlockingActorProxy , and so add a specific __getattr__ method for Meta classes ( BaseMeta).
But I faced recursion problems because at the end of the dataset class __init__, an update of the attributes of the datatree tries to fill the coverage (with the coverage property in the meta) that indirectly call to _bbox_ll. This last method wasn't found (recursion), I don't know why.
It should be good to make the reader being read an only time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant