Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide sidebar globally #943

Open
vg4tt0 opened this issue Jan 8, 2025 · 4 comments
Open

feat: hide sidebar globally #943

vg4tt0 opened this issue Jan 8, 2025 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vg4tt0
Copy link

vg4tt0 commented Jan 8, 2025

Describe your feature request

Django's default setting admin.site.enable_nav_sidebar = False should hide the sidebar collapse icon in the title

@lukasvinclav
Copy link
Contributor

What is the expected outcome of this flag? Are we going to completely hide the sidebar if the enable_nav_sidebar is set to False?

@vg4tt0
Copy link
Author

vg4tt0 commented Jan 14, 2025

That's correct and i think it's fine given the apps are listed on the app index page.

This is almost the case of the sidebar being completely hidden. Changing this flag to True currently hides the sidebar, however clicking on the dock_to_right icon while on the changeform page still shifts the footer (but not the page content) towards the right 72pts, as if the sidebar were still there but invisible.

@lukasvinclav
Copy link
Contributor

Okay, so if the enable_nav_sidebar is set to False, the sidebar is going to be completely hidden together with the "sidebar toggle" in the header before the title. What about the subpages (e.g. changelist)? Are we going to hide the sidebar there as well?

@vg4tt0
Copy link
Author

vg4tt0 commented Jan 14, 2025

Yes it should be global as originally intended

@lukasvinclav lukasvinclav changed the title Allow admin.site.enable_nav_sidebar = False to override unfold sidebar settings feat: hide sidebar globally Jan 14, 2025
@lukasvinclav lukasvinclav added enhancement New feature or request good first issue Good for newcomers labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants