Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_erp problems when using with_theme #261

Open
1 of 2 tasks
vladdez opened this issue Oct 23, 2024 · 1 comment
Open
1 of 2 tasks

plot_erp problems when using with_theme #261

vladdez opened this issue Oct 23, 2024 · 1 comment

Comments

@vladdez
Copy link
Collaborator

vladdez commented Oct 23, 2024

Describe the bug

  • linetype doesn't work
  • color doesn't work if scales_tmp is in draw
if !isa(plot_data[:, color_mapper][1], String) && color_type != nonnumeric
        scales_tmp = scales(Color = (; colormap = config.visual.colormap)) # for continuous
    else
        scales_tmp = scales(Color = (; palette = config.visual.color)) # for categorical
    end
    drawing = draw!(f_grid, plot_equation, scales_tmp; axis = config.axis)

code to reproduce

begin
    with_theme(Theme(
        palette = (color = [:red, :green], linestyle = [:dash, :dot]),
        Lines = (cycle = Cycle([:color, :linestyle], covary = true),)
    )) do
        plot_erp(results)
end
` ` ` 
@vladdez
Copy link
Collaborator Author

vladdez commented Nov 4, 2024

now I use

    scales_tmp = if !isa(plot_data[:, color_mapper][1], String) && color_type != nonnumeric
        drawing = draw!(
            f_grid,
            plot_equation,
            scales(Color = (; colormap = config.visual.colormap));
            axis = config.axis,
        ) # for continuous
    else
        drawing = draw!(f_grid, plot_equation; axis = config.axis) # for categorical
    end

@vladdez vladdez mentioned this issue Nov 6, 2024
vladdez added a commit that referenced this issue Nov 6, 2024
Prepublication
- #244 Added benchmarking with comparison of UM with MNE and MATLAB to measure speed of creating and updating figures. 
- adding supportive axes for `plot_topoplot`, `plot_topoplotseries`, `plot_butterfly` so now it is possible for users to change interpolations and axes of subplots
- adding Observables into `plot_topoplot`
- #245 was solved by adding `visual.colormap`
- #248 
- #240
- #257 
- #261 - issue with `with_theme`
- `Contribute` page added
- issues templates added
- upgrade Color and ColorTypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant