Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZeroTrie: Make plain ASCII and Ignore Case have same representation #5584

Open
sffc opened this issue Sep 24, 2024 · 1 comment
Open

ZeroTrie: Make plain ASCII and Ignore Case have same representation #5584

sffc opened this issue Sep 24, 2024 · 1 comment
Assignees
@sffc
Labels
2.0-breaking Changes that are breaking API changes C-unicode Component: Props, sets, tries T-enhancement Type: Nice-to-have but not required
Milestone
ICU4X 2.0 Stretch...

Comments

@sffc
Copy link
Member

sffc commented Sep 24, 2024

Currently they have different representations due to how they order strings. However, this is trivial to fix at runtime by writing a custom comparator in the binary search. Making them have the same representation would make it easier to swap between the two representations in the future without breaking data.
@sffc sffc added T-enhancement Type: Nice-to-have but not required C-unicode Component: Props, sets, tries labels Sep 24, 2024
@sffc sffc mentioned this issue Sep 29, 2024
Draft
@sffc sffc self-assigned this Jan 15, 2025
@Manishearth Manishearth added the 2.0-breaking Changes that are breaking API changes label Jan 15, 2025
@Manishearth
Copy link
Member

@sffc will devote some time to evaluate whether this is worth doing, and either complete #5615 or move this issue to 2.x priority / priority backlog after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
2.0-breaking Changes that are breaking API changes C-unicode Component: Props, sets, tries T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
ICU4X 2.0 Stretch ⟨P2⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth