Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out leap and keplr wallets from evm wallets list #2951

Open
o-az opened this issue Sep 13, 2024 · 0 comments
Open

filter out leap and keplr wallets from evm wallets list #2951

o-az opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
A-app Area: app.union.build E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-high High priority

Comments

@o-az
Copy link
Member

o-az commented Sep 13, 2024

problem:

leap does not work on ethereum and keplr force pops up every time you disconnect an evm wallet. Also both of them don't work in this example: https://eip6963.org

solution:

if you log this array, you will see a list of objects, each is a wallet. Each wallet has a name, id, etc. from which you can identify what the exact ids/keys for keplr and leap are, then simply add a filter at the end to filter them out. The filter has to be }) satisfies Array otherwise they can sneak in.

future plans

we add them back to evm wallets list (i.e. remove filter) once they work in the eip6963.org exampl same as other ones.

@o-az o-az added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-app Area: app.union.build P-high High priority labels Sep 13, 2024
@o-az o-az assigned Swepool and o-az and unassigned Swepool Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-app Area: app.union.build E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-high High priority
Projects
None yet
Development

No branches or pull requests

2 participants