Update workspace-card css to not specify z-index #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly displays on top of sibling workspace cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #36.
tooltip-bubblemodals are displaying incorrectly with sibling workspace cards.Solution
Updates the
workspace-cardcss class to not specifyz-index, allowing thetooltip-bubbleclass to correctly display on top of sibling workspace cards. Based on current css usage, this appears to be a simpler solution than adjusting thez-indexproperty of thetooltip-bubbleclass to be higher than theworkspace-cardclass:Caveats/Notes
I have little context on this application and its conventions, and I may be missing key context on why
workspace-cardhas thez-indexproperty defined that may make this solution insufficient. I am happy to iterate on this proposal if this solution is not possible.