Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original package.json file structure is not respected #132

Closed
helltraitor opened this issue Jul 24, 2023 · 2 comments · Fixed by #175
Closed

Original package.json file structure is not respected #132

helltraitor opened this issue Jul 24, 2023 · 2 comments · Fixed by #175

Comments

@helltraitor
Copy link

Environment

Not involved

Reproduction

Steps to reproduce

  1. Add new line at the end of the package.json
  2. Run changelogen --release command

Expected

Changes in the version line only

Actual

Last line removed

Describe the bug

changelogen uses external tool pkg-types, that does nothing special, just 1 line to be honest. And that leads to undesired behavior when the last line removes

Additional context

I've just noticed that changelogen uses pkg-types which ignores the use case when eol-last preferred. You maybe already noticed that changelogen "removes" last line in package.json because relies on external util, which doesn't care about user preferences

I think that this is an important issue, since it's requires for end user to change eslint rules.

Possible solution: wait for implementation of unjs/changelogen#130 which will allow to release without version changing and hence must not override package.json file

Desired solution: change version inplace instead of overriding whole file

Logs

No response

@pi0
Copy link
Member

pi0 commented Jul 24, 2023

PR welcome for pkg-types to respect EOL. It is using across ecosystem 👍🏼

@pi0 pi0 transferred this issue from unjs/changelogen Jul 24, 2023
@samydoesit
Copy link

What about #113? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants