Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppBarButton and Button behave differently when interacting with them. #1368

Open
5 tasks done
Suriman opened this issue Mar 22, 2024 · 1 comment
Open
5 tasks done
Labels
kind/bug Something isn't working

Comments

@Suriman
Copy link

Suriman commented Mar 22, 2024

Current behavior

There are some differences in the behavior of both controls. For instance, when hovering the AppBarButton does not react as it is the case with the regular Button. There is also no difference in the appearance of the AppBarButton when it is enabled or disabled. This makes it difficult for the user to know if the associated command is available or not. There are other visual states, like 'Pressed' and 'Focused' where no effects can be applied.

Expected behavior

The AppBarButton should react to user interaction and changes on the enabled state.

How to reproduce it (as minimally and precisely as possible)

ButtonAndAppBarButtonBehaveDifferently.zip

  1. Open the attached solution and compile it.
  2. Execute it in any head given.
  3. Hover the AppBarButton and the Button to see the difference.
  4. Check and uncheck the CheckBox to see the different behaviors of both controls.

Environment

Nuget Package:

NuGet package(s): Uno.WinUI
NuGet package version(s): Uno.WinUI 5.1.80

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • MacOS

Anything else we need to know?

@Suriman Suriman added the kind/bug Something isn't working label Mar 22, 2024
@kazo0
Copy link
Collaborator

kazo0 commented Mar 23, 2024

The Material AppBarButton styles were mostly there for the native NavigationBar commands but I agree that if we are going to set them as the implicit style for AppBarButton then they should really be a complete style. Right now the template is extreme barebones.

Would be good to bring the visual states and structure from the original Fluent style and use the Material resources.

Thanks for the report @Suriman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants