Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] NavigationBar SecondaryCommands empty without Label #1484

Open
morning4coffe-dev opened this issue Sep 19, 2024 · 10 comments
Open

Comments

@morning4coffe-dev
Copy link
Member

This is out of the box from the template where I picked the Fluent Design, I've only added the AppBarButton in Secondary Commands
UnoApp5.zip
Screenshot 2024-09-18 171024
Screenshot 2024-09-18 171130

Originally posted by @WenHong-Lau in unoplatform/uno#18233 (comment)

This seems to be an issue on newer Android versions.

@WenHong-Lau
Copy link

Actually this happens on light theme as well, could not see the text in the SecondaryCommands

@jeromelaban jeromelaban transferred this issue from unoplatform/uno.toolkit.ui Sep 24, 2024
@kazo0
Copy link
Collaborator

kazo0 commented Sep 30, 2024

@WenHong-Lau / @morning4coffe-dev Does anything show up if you set the Label property of the AppBarButtons?

@morning4coffe-dev
Copy link
Member Author

@kazo0 Jup, this does work correctly with Label... but it should probably at least show the icon of the AppBarButton.

@WenHong-Lau You can use something like this to display the SecondaryCommand properly:

AppBarButton Icon="Add" Label="Add"/>

@morning4coffe-dev morning4coffe-dev changed the title [Android] NavigationBar SecondaryCommands doesn't respect dark theme [Android] NavigationBar SecondaryCommands empty without Label Oct 1, 2024
@WenHong-Lau
Copy link

Still not showing on my end.
image

@morning4coffe-dev
Copy link
Member Author

@WenHong-Lau And when you set only the Label and not the Content?

@WenHong-Lau
Copy link

@morning4coffe-dev Tested that, still the same outcome, not visible.

@morning4coffe-dev
Copy link
Member Author

Interesting... I did try it yesterday and it showed. I will make a repro, if you can try it on your side. Thanks.

@morning4coffe-dev
Copy link
Member Author

Here is what I see on my side with Android API 34:

image

Here is the repro. Can you try on your side?
NavigationBar.zip

@WenHong-Lau
Copy link

Can you try it on dark mode? I still can't see the AppBarButtons
image

@morning4coffe-dev
Copy link
Member Author

morning4coffe-dev commented Oct 2, 2024

Ok, I see it as well again. Thank you, @WenHong-Lau. I make a new issue to track both problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants