Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Gatekeeper succeeds before all status checks are completed #84

Open
smokhasi opened this issue Jan 30, 2025 · 1 comment
Open

Comments

@smokhasi
Copy link

We use Merge Gatekeeper across all our projects and have found it to be an excellent tool for overcoming some limitations of GitHub Actions.

Recently, we added Playwright end-to-end integration tests as status checks in our internal application repository. These tests are triggered only after the build, lint, and unit test checks, which take approximately 10 minutes to complete.

However, since the Playwright check is not part of the initial set of checks that run when a PR is opened, we are encountering an issue where Merge Gatekeeper marks the PR as successful before the Playwright tests have even started.

Expected Behavior
We would like Merge Gatekeeper to consider the Playwright tests before allowing a PR to be merged.

Questions:

  • Is there a way to specify certain jobs as required when Merge Gatekeeper is triggered, particularly for specific file paths?
  • Alternatively, can Merge Gatekeeper periodically re-check the list of jobs after initially succeeding to ensure that all relevant checks have completed?

Would appreciate any guidance on how to configure this behavior. Thanks!

@smokhasi smokhasi changed the title Merge Gatekeeper Succeeds Before All Status Checks Are Completed Merge Gatekeeper succeeds before all status checks are completed Jan 30, 2025
@smokhasi
Copy link
Author

smokhasi commented Feb 4, 2025

Overcame this limitation by using myrotvorets/set-commit-status-action. Spoofed the context and commit_sha, and set the status to pending until the playwright check starts

    steps:
      - uses: myrotvorets/set-commit-status-action@master
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          state: pending
          description: 'Tests are yet to run...'
          context: 'your context here'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant