Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI (appveyor) #145

Open
jameslamb opened this issue Mar 4, 2019 · 1 comment
Open

Add Windows CI (appveyor) #145

jameslamb opened this issue Mar 4, 2019 · 1 comment

Comments

@jameslamb
Copy link
Collaborator

jameslamb commented Mar 4, 2019

Currently, we have no tests on whether the R or Python packages work on Windows. Should add some CI using Appveyor to test this. See for example https://github.com/jameslamb/rsixygen/blob/master/appveyor.yml

It would be valuable to do this with two PRs:

  1. (easier) test that the libraries can even be installed
    2. (harder) test the libraries against actual running Elasticsearch

For whoever picks up number 2...I don't think it's worthwhile to test against all of the historical versions. It's sufficient to only test on windows against the most recent version of Elasticsearch.

References

Theoretically it's possible to run Elasticsearch on Windows: https://www.elastic.co/guide/en/elasticsearch/reference/current/windows.html

@jameslamb
Copy link
Collaborator Author

To close this issue, I actually think it would be ok to just install the package, set whatever environment variable tells testthat that it's on CRAN, and then runs the tests. The integration tests would all be skipped (only unit tests would be run) but that would still be a big improvement over the current state.

In other you do not need to set up Elasticsearch on Windows to address this issue

@jameslamb jameslamb changed the title Add Windows CI Add Windows CI (appveyor) Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant