Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 factor authentication support #810

Open
dransome opened this issue Oct 31, 2017 · 5 comments
Open

2 factor authentication support #810

dransome opened this issue Oct 31, 2017 · 5 comments
Labels
core feature request Feature request up-for-grabs Not assigned yet
Milestone

Comments

@dransome
Copy link

As discussed with @alexweissman on chat, I would like to see 2FA in UF.

https://github.com/RobThree/TwoFactorAuth was noted as a possible starting point.

@alexweissman alexweissman added core feature request Feature request up-for-grabs Not assigned yet labels Nov 2, 2017
@stale
Copy link

stale bot commented May 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 6, 2019
@stale stale bot closed this as completed May 13, 2019
@ghost
Copy link

ghost commented Nov 12, 2021

@dransome
@alexweissman

Hi

This feature request for 2FA is ~ 4 yrs old now.

Everything else about UserFrosting looks really modern and has been getting updates to latest PHP , tech, etc.

Did 2FA get implemented for UserFrosting and just not get added here? For login with Google Auth, Authy, Yubikey, etc?

Thanks!

@Silic0nS0ldier
Copy link
Member

Not implemented, and from the history this was closed by stalebot during its brief stint.

There are a few areas to consider in adding 2FA support.

  1. How should the security be modeled? GitHub for example requires that the 2FA workflow have been used recently to access sensitive areas such as settings.
  2. What would account recovery look like? The current workflow allows a password reset so long as the user has access to their email.
  3. What happens if someone losses their 2FA? GitHub offers a solution in the form of a handful of single-use codes.
  4. How do we ensure that apps which use an API backed by UserFrosting aren't locked-out unintentionally by implementors enabling 2FA support without updating their apps?

@Silic0nS0ldier Silic0nS0ldier removed the wontfix This will not be worked on label Nov 13, 2021
@ghost
Copy link

ghost commented Nov 13, 2021

I really don't know all the nuts & bolts, just that I use 2FA 'everywhere' these days. Mostly with Google-type OTP tokens, a lot with Yubi keys, more and more with push auth like PingID or DuoSecurity, and still some with TXT message tokens.

When I started looking into this, it seems like rolling your own 2FA is just as common as doing your own User Management.

I use Authy to generate my 2FA tokens everywhere, so I 1st started looking around at how they do it.

I found this framework,

https://www.twilio.com/docs/authy

which has an API and good docs.

I also found this

https://github.com/scheb/2fa
https://symfony.com/bundles/SchebTwoFactorBundle/5.x/index.html

which looks like another framework mostly for Symfony, and so Laravel too?, that has thought through a bunch of it.

I really don't have the knowhow to code the whole thing custom from scratch. Especially for each & every web app.Which is why I came looking for and was excited to find UserFrosting!

And sounds like you already know about GH 2FA a bit

https://docs.github.com/en/authentication/securing-your-account-with-two-factor-authentication-2fa

@TheMainJoe
Copy link

A bit late to the party...

I once implemented authy 2FA (https://www.twilio.com/docs/authy) into UF3 a few years ago, I started a sprinkle at some point to try and get it in, but life happened.

To go with something like authy or authenticator would be a nicer option as it would cover losing 2FA as it is linked to and email address and a phone number. The application also has a bit of a footprint as being available for mobile and desktop I am having more and more free time and very willing to assist where I can.

@lcharette lcharette modified the milestones: No Milestone, 6.0.0 Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature request Feature request up-for-grabs Not assigned yet
Projects
Status: References
Development

No branches or pull requests

5 participants