Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Localization of "End of Posts" string in feed.component.html in English #4988

Closed
kivuvarosekivuvan opened this issue Aug 12, 2024 · 1 comment · Fixed by ushahidi/platform-client-mzima#1182 or ushahidi/platform-client-mzima#1183

Comments

@kivuvarosekivuvan
Copy link

Summary

Describe the bug

The string "End of Posts" on line 290 in the feed.component.html file needs to be localized

To Reproduce

  1. Navigate to the apps/web-mzima-client/src/app/feed/feed.component.html file.
  2. Locate the following code block on line 290:
<div class="endofPosts" *ngIf="!loadingMorePosts && postCurrentLength >= total">
  End of Posts
</div>

Expected behavior

The "End of Posts" string should be localized and retrieved from a translation file or service, so that it can be displayed in English

How to solve

  1. In the feed.component.html file, replace the hardcoded "End of Posts" string with a translation key ( something like., {{ 'FEED.END_OF_POSTS' | translate }})

Screenshots

Screenshot 2024-07-24 at 09 42 44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment