fix: show autoform non-rendered property errors #2833
+326
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
==========================================
+ Coverage 92.72% 92.77% +0.04%
==========================================
Files 83 83
Lines 2845 2850 +5
Branches 728 730 +2
==========================================
+ Hits 2638 2644 +6
Misses 156 156
+ Partials 51 50 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cromoteca
requested changes
Oct 17, 2024
| } | ||
|
|
||
| public static class NullableFieldModel { | ||
| @Id |
There was a problem hiding this comment.
Those fields look nullable by default, unless I'm missing something. You should probably test them under a @NonNullApi annotation.
There was a problem hiding this comment.
I should, but I should also check that they are indeed nullable without any other annotation.
I will add another test.
krissvaa
force-pushed
the
fix/crud-ignored-property-errors
branch
from
39d5488
to
35f6656
Compare
Fixes: #2217
krissvaa
force-pushed
the
fix/crud-ignored-property-errors
branch
from
35f6656
to
74b4a76
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show autoform non-rendered property errors
Make @id and @Version annotations resolve as nullable fields
Fixes: #2217
Fixes: #2809