mui-pickers-v3. #42
Comments
|
Thanks a lot for this. I am a noob when it comes to web development, so I'd love it if you could publish your fork through npm where I could pick it up easily. 😊 Thanks again for your efforts. ❤️ |
|
Thank you!
|
|
I have already upgraded the repo to reac-admin v3 and mui-pickers v3 2 months ago. |
|
They finally merge it! In using the one in my fork since I believe is more visually consistent with the latest version of react-admin, plus I've added other components, but since yours have been merged, I could send a PR with the changes. Could you check my fork and give me some feedback? |
@WiXSL You could apply your changes to the current merged code to make it more consistent. |
|
I've created the PR. https://github.com/vascofg/react-admin-date-inputs/pull/47/files |
|
@WiXSL Will this be on NPM today? |
|
No, when it gets merge, if it's accepted.
|
|
Thanks it work great with v3, I just have one question, using |
|
I belive passing |
|
cannot run when usage @WiXSL Exception is thrown |
|
@chungchi300 using your code i only get complaints from react about the format. it should be: Other than that it works. |
|
weird, is that may dependency has some problem? My npm ls package.json |
|
I use lerna to install my dependency @WiXSL |
|
Do you see v4 migration being difficult when it's available? We are having issues with the current on mobile (safari/chrome) converting to UTC time instead of user's local; fine on desktop and even my phone so maybe browser-specific. Also, really could use the DateRangePicker being added to v4. |
|
@fancyaction I upgraded this component to V4, see issue #51. Not fully tested, but it's a start |
|
@WiXSL I'm trying to use https://github.com/WiXSL/react-admin-date-inputs/tree/mui-pickers-v3 but it has an error: I use yarn and added the package to the package.json : |
|
@aalinia, try with |
Tried it. Here is the result: package.json: |
|
@WiXSL I also was wondering if the support for Jalaali/Hijri calendar systems can be added? |
|
Your getting an error on your side
|
@WiXSL I think it's because of
Should I fork yours? Is your fork is merged yet? |
|
|
|
Dear @WiXSL and all guys, |
|
@shinaBR2 I've added some fixes in my fork. |
|
@WiXSL I will do tomorrow 🎉 |
|
@WiXSL, Why the input is always shrinked? |
|
@hallboav, You have to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've created a branch in my fork compatible with react-admin v3.
material-ui-pickerschange to@material-ui/pickersv3.useInputinstead of the deprecatedaddField.KeyboardDateInput,KeyboardDateTimeInputandKeyboardTimeInput.DateInputcomponent for consistency with the rest of react-admin input components.You can check it out here:
https://github.com/WiXSL/react-admin-date-inputs/tree/mui-pickers-v3
The text was updated successfully, but these errors were encountered: