Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix year-dependent VRL tests #8

Open
bruceg opened this issue Jan 4, 2023 · 1 comment
Open

Fix year-dependent VRL tests #8

bruceg opened this issue Jan 4, 2023 · 1 comment
Labels
domain: tests Anything related to internal tests type: tech debt A code change that does not add user value vrl: stdlib Changes to the standard library

Comments

@bruceg
Copy link
Member

bruceg commented Jan 4, 2023

With vectordotdev/vector#15797 we applied a bandaid to the two year-dependent VRL tests, parse_klog and parse_linux_authorization, but they will again fail next year if nothing is changed. This needs to be resolved so we don't continue to have yearly issues with these tests.

@bruceg bruceg added domain: tests Anything related to internal tests type: tech debt A code change that does not add user value vrl: stdlib Changes to the standard library labels Jan 4, 2023
@fuchsnj fuchsnj transferred this issue from vectordotdev/vector Mar 28, 2023
jszwedko added a commit to vectordotdev/vector that referenced this issue Jan 2, 2025
@pront
Copy link
Member

pront commented Jan 2, 2025

Sample output from https://github.com/kubernetes/klog/blob/main/examples/log_file/usage_log_file.go:

Log file created at: 2025/01/02 13:41:35
Running on machine: COMP-LPF0JYPP2Q
Binary: Built with gc go1.23.4 for darwin/arm64
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
I0102 13:41:35.886784   42875 usage_log_file.go:17] nice to meet you
Log file created at: 2025/01/02 13:41:37
Running on machine: COMP-LPF0JYPP2Q
Binary: Built with gc go1.23.4 for darwin/arm64
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
I0102 13:41:37.379107   42902 usage_log_file.go:17] nice to meet you

Year is not included. I wonder if creating a timestamp with the current year is the wrong thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: tests Anything related to internal tests type: tech debt A code change that does not add user value vrl: stdlib Changes to the standard library
Projects
None yet
Development

No branches or pull requests

2 participants