Skip to content

Commit ff4aef8

Browse files
authoredSep 1, 2022
Merge pull request #30 from Mondotosz/master
fix: matched offsetSet and offsetUnset signature
2 parents cfd7008 + 3d413c2 commit ff4aef8

File tree

5 files changed

+546
-637
lines changed

5 files changed

+546
-637
lines changed
 

‎.github/workflows/test.yml

+6-8
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,9 @@ jobs:
55
runs-on: ubuntu-20.04
66
strategy:
77
matrix:
8-
php: [ 7.4, 8.0, 8.1]
8+
php: [ 8.0, 8.1]
99
laravel: [9.*, 8.*, 7.*]
1010
exclude:
11-
- laravel: 9.*
12-
php: 7.4
1311
- laravel: 7.*
1412
php: 8.1
1513
include:
@@ -62,8 +60,8 @@ jobs:
6260
token: ${{ secrets.CODECOV_TOKEN }}
6361
file: ./clover.xml
6462

65-
- name: send coverage to codacy.com
66-
uses: codacy/codacy-coverage-reporter-action@master
67-
with:
68-
project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
69-
coverage-reports: clover.xml
63+
# - name: send coverage to codacy.com
64+
# uses: codacy/codacy-coverage-reporter-action@master
65+
# with:
66+
# project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
67+
# coverage-reports: clover.xml

‎README.md

+6-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,12 @@ Automatic HashId generator for your eloquent model.
1212

1313
### Version Compatibilities
1414

15-
| Laravel HashId | PHP Version | Laravel 5.* | Laravel 6.* | Laravel 7.* | Laravel 8.* | Laravel 9.* |
16-
|---------------- |:---------------------: |:------------------: |:------------------: |:------------------: |:------------------: |:------------------: |
17-
| `1.x` | `>=7.0` | :white_check_mark: | :white_check_mark: | :x: | :x: | :x: |
18-
| `2.x` | `>=7.2` - `<= 8.0` | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
19-
| `3.x` | `>=7.4` \|\| `>= 8.0` | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
15+
| Laravel HashId | PHP Version | Laravel 5.* | Laravel 6.* | Laravel 7.* | Laravel 8.* | Laravel 9.* |
16+
|------------------|:----------------------:|:------------------: |:------------------: |:------------------: |:------------------: |:------------------: |
17+
| `1.x` |`>=7.0` | :white_check_mark: | :white_check_mark: | :x: | :x: | :x: |
18+
| `2.x` |`>=7.2` - `<= 8.0` | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
19+
| `3.0` | `>=7.4` \ |\| `>= 8.0` | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
20+
| `3.1` | `>= 8.0` | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
2021

2122
### Install
2223

‎composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
}
1111
],
1212
"require": {
13-
"php" : "^7.4 || ^8.0",
13+
"php" : "^8.0",
1414
"hashids/hashids": "^4.0",
1515
"illuminate/contracts": ">=6.18",
1616
"illuminate/config": ">=6.18",

‎composer.lock

+531-621
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/Repository.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ public function offsetGet($offset): Hashids
8383
}
8484

8585
/** {@inheritdoc} */
86-
public function offsetSet($offset, $value)
86+
public function offsetSet(mixed $offset, mixed $value): void
8787
{
8888
$this->set($offset, $value);
8989
}
9090

9191
/** {@inheritdoc} */
92-
public function offsetUnset($offset)
92+
public function offsetUnset(mixed $offset): void
9393
{
9494
unset($this->hashes[$offset]);
9595
}

0 commit comments

Comments
 (0)
Please sign in to comment.