Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to customize the prompt #33

Open
andrm opened this issue Jun 21, 2018 · 5 comments
Open

Provide a way to customize the prompt #33

andrm opened this issue Jun 21, 2018 · 5 comments

Comments

@andrm
Copy link
Contributor

andrm commented Jun 21, 2018

Currently I don't see a way to customize the prompt of the ShellServer.
@vietj
Copy link
Contributor

vietj commented Jun 21, 2018

can you contribute this feature ?

@andrm
Copy link
Contributor Author

andrm commented Jun 22, 2018

See pull req #34

@andrm
Copy link
Contributor Author

andrm commented Jun 24, 2018

PR merged.

@andrm andrm closed this as completed Jun 24, 2018
@vietj vietj added this to the 3.6.0 milestone Jun 24, 2018
@andrm
Copy link
Contributor Author

andrm commented Jun 28, 2018

The feature is pretty useless right now. I can't set the prompt from a process since the running Shell is not available.
Neither is it possible to set the prompt from the ShellServer, ShellService, TermServer or Term instance, there is no "connectionHandler" in these classes.
What is missing?

@andrm andrm reopened this Jun 28, 2018
@vietj
Copy link
Contributor

vietj commented Jun 28, 2018

waht's your actual deployment ?

@vietj vietj modified the milestones: 3.6.0, 4.0.0 Nov 29, 2018
@vietj vietj removed this from the 4.0.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vietj @andrm