-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another type of tests: testing that WLA's/WLALINK's verbose mode's output contains a string #485
Comments
We can tail the output and then grep for that line. It would be helpful if CONTRIBUTING.md contained instructions on how to add tests. |
Quick note about adding tests: a) Clone an existing test directory and modify it No need to list the new tests anywhere, a directory inside tests is considered one test directory But sure, CONTRIBUTING.md should be updated about this... |
Does the test harness require us to create makefiles for tests though? I feel like this test can be done in a bash script. |
Yep, every test folder needs to have a makefile that runs the test. Just
make a makefile to run the bash script…
…On Tue, 21 Feb 2023 at 20:06, Jeff Linahan ***@***.***> wrote:
Does the test harness require us to create makefiles for tests though? I
feel like this test can be done in a bash script.
—
Reply to this email directly, view it on GitHub
<#485 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQ62UWPRD3R3M354XMC74LWYT723ANCNFSM5PLPS2JA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Maybe, but I can live with this |
This is something we'd need in "tests/z80/ram_sections_2".
Currently the output is:
What in this test is important that the last line reads:
It'd be great if we could create a test that'd verify this.
The text was updated successfully, but these errors were encountered: