Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] [APP-6233] [RSDK-7052] Various Small Fixes #41

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

Otterverse
Copy link
Member

No description provided.

@Otterverse Otterverse changed the title [RSDK-9260] [RSDK-9252] Misc Fixes [RSDK-9260] [RSDK-9252] [APP-6402] Misc Fixes Nov 13, 2024
@Otterverse Otterverse changed the title [RSDK-9260] [RSDK-9252] [APP-6402] Misc Fixes [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] Misc Fixes Nov 13, 2024
@Otterverse Otterverse changed the title [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] Misc Fixes [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] Various Small Fixes Nov 13, 2024
@Otterverse Otterverse changed the title [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] Various Small Fixes [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] [APP-6233] Various Small Fixes Nov 13, 2024
@Otterverse Otterverse changed the title [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] [APP-6233] Various Small Fixes [RSDK-9260] [RSDK-9252] [APP-6402] [APP-6234] [APP-5296] [APP-6233] [RSDK-7052] Various Small Fixes Nov 13, 2024
@Otterverse Otterverse marked this pull request as ready for review November 14, 2024 18:48
@Otterverse
Copy link
Member Author

@michaellee1019 Review only if you have time, but this should fix several issues you had with preinstall (both the scrdipt and early functionality.)

You'd also mentioned earlier today (thursday) you'd seen another issue with a bad PSK causing problems, so wondering if you reproduced that or not. If so, I will probably want to make sure a fix for that gets in here as well.

@michaellee1019
Copy link
Member

Will do more testing this afternoon, currently bug reporting has been mixed with testing for the agent ui updates. Its feeling like the issues im seeing are non deterministic, but probably can narrow it down by changing less config each time to repro the exact situation.

Still working on testing this binary, because im using MacOS need to build within canon and still working on setting up a good image to test with.

@michaellee1019
Copy link
Member

Didnt get to more testing today. Will do first thing monday. If you want, merge this so it makes the next release and can do the rest in another PR.

@Otterverse
Copy link
Member Author

Didnt get to more testing today. Will do first thing monday. If you want, merge this so it makes the next release and can do the rest in another PR.

I'm traveling today, so no rush. I'm going to go ahead and merge this (but NOT release a build yet) so Benji's and Ale's PRs aren't blocked. If you repro, will do another bugfix PR for that issue.

@Otterverse Otterverse merged commit f64a0c9 into main Nov 18, 2024
1 check passed
@Otterverse Otterverse deleted the smallfixes branch November 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants