[APP-7026] Handle rfkill, no-wifi-device cases #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otterverse
commented
Nov 19, 2024
| @@ -4,7 +4,7 @@ go 1.23.1 | |||
|
|
|||
| require ( | |||
| github.com/Masterminds/semver/v3 v3.3.0 | |||
| github.com/Otterverse/gonetworkmanager/v2 v2.2.0 | |||
| github.com/Otterverse/gonetworkmanager/v2 v2.2.1 | |||
There was a problem hiding this comment.
Small patch over there to add GetPropertyRadioFlags()
|
|
||
| timeoutCtx, cancel := context.WithTimeout(ctx, time.Second*10) | ||
| defer cancel() | ||
| for { |
There was a problem hiding this comment.
Without this loop the first scan fails and throws an error, as it takes a couple seconds for the radio to power on.
| @@ -332,12 +332,3 @@ func ConvertAttributes[T any](attributes *structpb.Struct) (*T, error) { | |||
|
|
|||
| return newConfig, nil | |||
| } | |||
|
|
|||
| func Sleep(ctx context.Context, timeout time.Duration) bool { | |||
There was a problem hiding this comment.
This is just drive-by cleanup. Nothing uses this anymore.
ale7714
approved these changes
Nov 20, 2024
| @@ -124,6 +124,18 @@ func (w *Provisioning) getNM() (gnm.NetworkManager, error) { | |||
| return nil, nmErr | |||
| } | |||
|
|
|||
| flags, err := nm.GetPropertyRadioFlags() | |||
| if err != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two cases... the first, in the bug, is when the wifi is blocked by rfkill (aka, "airplane mode".) This has recently (past week) become the default for new Raspberry Pi image installs unless the user specifically adds a wifi network during the image creation process.
The second case is for devices that have no wifi adapters at all. Previously, results were undefined, and provisioning would continue trying to execute, scan, start hotspots, etc. even if that wasn't possible. Now the lack of wifi hardware causes provisioning to self-disable until the next restart of agent.