[APP-7026] Handle rfkill, no-wifi-device cases

go.mod

@@ -4,7 +4,7 @@ go 1.23.1
 
 require (
 	github.com/Masterminds/semver/v3 v3.3.0
-	github.com/Otterverse/gonetworkmanager/v2 v2.2.0
+	github.com/Otterverse/gonetworkmanager/v2 v2.2.1
 	github.com/google/uuid v1.6.0
 	github.com/jessevdk/go-flags v1.6.1
 	github.com/nightlyone/lockfile v1.0.0

go.sum

@@ -61,8 +61,8 @@ github.com/Masterminds/sprig v2.15.0+incompatible/go.mod h1:y6hNFY5UBTIWBxnzTeuN
 github.com/Masterminds/sprig v2.22.0+incompatible/go.mod h1:y6hNFY5UBTIWBxnzTeuNhlNS5hqE0NB0E6fgfo2Br3o=
 github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=
 github.com/OpenPeeDeeP/depguard v1.0.1/go.mod h1:xsIw86fROiiwelg+jB2uM9PiKihMMmUx/1V+TNhjQvM=
-github.com/Otterverse/gonetworkmanager/v2 v2.2.0 h1:aYEOjBO2I+OMORNpCBXqvVgzHcGks5MWmKv0JmrT5po=
-github.com/Otterverse/gonetworkmanager/v2 v2.2.0/go.mod h1:Bc8kOugBgzCBC0R8oLa3wHnGet7k2ZpMHUobZtxlwhU=
+github.com/Otterverse/gonetworkmanager/v2 v2.2.1 h1:yNov3VIkatRprIhCkoshWEeUG4pyNPJQMLHSFXqi09g=
+github.com/Otterverse/gonetworkmanager/v2 v2.2.1/go.mod h1:Bc8kOugBgzCBC0R8oLa3wHnGet7k2ZpMHUobZtxlwhU=
 github.com/PuerkitoBio/goquery v1.6.0/go.mod h1:GsLWisAFVj4WgDibEWF4pvYnkVQBpKBKeU+7zCJoLcc=
 github.com/Shopify/sarama v1.19.0/go.mod h1:FVkBWblsNy7DGZRfXLU0O9RCGt5g3g3yEuWXgklEdEo=
 github.com/Shopify/toxiproxy v2.1.4+incompatible/go.mod h1:OXgGpZ6Cli1/URJOF1DMxUHB2q5Ap20/P/eIdh4G0pI=

subsystems/provisioning/provisioning.go

@@ -29,7 +29,6 @@ type Provisioning struct {
 	monitorWorkers sync.WaitGroup
 
 	// blocks start/stop/etc operations
-	// holders of this lock must use HealthySleep to respond to HealthChecks from the parent agent during long operations
 	opMu     sync.Mutex
 	running  bool
 	disabled bool
@@ -95,6 +94,7 @@ func NewProvisioning(ctx context.Context, logger logging.Logger, updateConf *age
 func (w *Provisioning) getNM() (gnm.NetworkManager, error) {
 	nmErr := errw.New("NetworkManager does not appear to be responding as expected. " +
 		"Please ensure NetworkManger >= v1.42 is installed and enabled. Disabling agent-provisioning until next restart.")
+	wifiErr := errw.New("No WiFi devices available. Disabling agent-provisioning until next restart.")
 
 	nm, err := gnm.NewNetworkManager()
 	if err != nil {
@@ -124,6 +124,18 @@ func (w *Provisioning) getNM() (gnm.NetworkManager, error) {
 		return nil, nmErr
 	}
 
+	flags, err := nm.GetPropertyRadioFlags()
+	if err != nil {
+		w.noNM = true
+		w.logger.Error(err)
+		return nil, wifiErr
+	}
+
+	if flags&gnm.NmRadioFlagsWlanAvailable != gnm.NmRadioFlagsWlanAvailable {
+		w.noNM = true
+		return nil, wifiErr
+	}
+
 	return nm, nil
 }
 
@@ -159,6 +171,10 @@ func (w *Provisioning) init(ctx context.Context) error {
 		return err
 	}
 
+	if err := w.enableWifi(ctx); err != nil {
+		return err
+	}
+
 	if err := w.initDevices(); err != nil {
 		return err
 	}

subsystems/provisioning/setup.go

@@ -4,9 +4,11 @@ package provisioning
 
 import (
 	"bytes"
+	"context"
 	"errors"
 	"io/fs"
 	"os"
+	"time"
 
 	gnm "github.com/Otterverse/gonetworkmanager/v2"
 	errw "github.com/pkg/errors"
@@ -139,3 +141,24 @@ func (w *Provisioning) initDevices() error {
 
 	return nil
 }
+
+func (w *Provisioning) enableWifi(ctx context.Context) error {
+	if err := w.nm.SetPropertyWirelessEnabled(true); err != nil {
+		return err
+	}
+
+	timeoutCtx, cancel := context.WithTimeout(ctx, time.Second*10)
+	defer cancel()
+	for {
+		if !w.mainLoopHealth.Sleep(timeoutCtx, time.Second) {
+			return errw.Wrap(timeoutCtx.Err(), "enabling wifi")
+		}
+		enabled, err := w.nm.GetPropertyWirelessEnabled()
+		if err != nil {
+			return err
+		}
+		if enabled {
+			return nil
+		}
+	}
+}

utils.go

@@ -332,12 +332,3 @@ func ConvertAttributes[T any](attributes *structpb.Struct) (*T, error) {
 
 	return newConfig, nil
 }
-
-func Sleep(ctx context.Context, timeout time.Duration) bool {
-	select {
-	case <-ctx.Done():
-		return false
-	case <-time.After(timeout):
-		return true
-	}
-}