Fix wifi candidate selection to include non-interface-bound candidates #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale7714
reviewed
Dec 4, 2024
ale7714
approved these changes
Dec 4, 2024
Otterverse
force-pushed
the
primarynet
branch
from
dcc702b to
eb2d73f
Compare
ale7714
approved these changes
Dec 4, 2024
Otterverse
commented
Dec 4, 2024
| @@ -183,7 +183,7 @@ func main() { | |||
| } | |||
|
|
|||
| // wait until now when we (potentially) have a network logger to record this | |||
| globalLogger.Infof("Viam Agent Version: %s\nGit Revision: %s\n", agent.GetVersion(), agent.GetRevision()) | |||
| globalLogger.Infof("Viam Agent Version: %s Git Revision: %s", agent.GetVersion(), agent.GetRevision()) | |||
There was a problem hiding this comment.
drive-by... didn't realize I'd copy/pasted the newlines from the CLI "version" output here (where it makes no sense.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wifi networks found from scan were associated with the scanning interface (e.g. wlan0) but externally configured wifi settings (e.g. prexisting networks) might not be associated with a specific interface. Thus, duplicate networks (one for "any" and one for "wlan0" were causing issues.
This PR should deduplicate the two maps. If a connection/settings has no interface associated (and it's wifi) it gets handled as though it WAS associated with the current HotspotInterface (can be configured, otherwise first detected wifi adapter.)