-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-7007] Add prerelease and other build automation #74
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6a601f5
Add support for pre-release builds from main
Otterverse a48b161
Fix and run tests
Otterverse 0243521
Test url
Otterverse cf4a4f3
typos
Otterverse 49a1199
typo
Otterverse d3e9a32
typo
Otterverse 7271300
typo
Otterverse ef98e38
smurf
Otterverse 560ed69
testing
Otterverse 24cf03f
testing
Otterverse 5774586
testing
Otterverse ce977bc
Hopefully final-ish
Otterverse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,16 +65,21 @@ func TestConvertJson(t *testing.T) { | |
err := json.Unmarshal([]byte(jsonBytes), newConfig) | ||
|
||
testConfig := DefaultConfig() | ||
testConfig.AdditionalNetworks["network1"] = NetworkDefinition{ | ||
Type: "wifi", | ||
Interface: "wlan0", | ||
SSID: "foo", | ||
PSK: "bar", | ||
IPv4Address: "192.168.0.1/24", | ||
IPv4Gateway: "192.168.0.255", | ||
IPv4DNS: []string{"192.168.0.255"}, | ||
testConfig.AdditionalNetworks = map[string]NetworkDefinition{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test was borked, so fixing now that we run these in automation. |
||
"network1": { | ||
Type: "wifi", | ||
Interface: "wlan0", | ||
SSID: "foo", | ||
PSK: "bar", | ||
IPv4Address: "192.168.0.1/24", | ||
IPv4Gateway: "192.168.0.255", | ||
IPv4DNS: []string{"192.168.0.255"}, | ||
}, | ||
"network2": { | ||
SSID: "moo", | ||
PSK: "cow", | ||
}, | ||
} | ||
testConfig.AdditionalNetworks["network2"] = NetworkDefinition{SSID: "moo", PSK: "cow"} | ||
|
||
test.That(t, err, test.ShouldBeNil) | ||
test.That(t, *newConfig, test.ShouldResemble, testConfig) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will edit these to real destinations after some real world testing (e.g. sometime after this merge.) Want to make sure App's discovery isn't going to barf on the new -dev.X syntax in the filenames and break things.