[APP-7700] Fix repetitive wifi scan unavailable errors #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otterverse
force-pushed
the
fix-scan-unavailable
branch
from
dc37b02 to
cb3f523
Compare
Otterverse
commented
Feb 24, 2025
| @@ -4,7 +4,7 @@ go 1.23.1 | |||
|
|
|||
| require ( | |||
| github.com/Masterminds/semver/v3 v3.3.0 | |||
| github.com/Otterverse/gonetworkmanager/v2 v2.2.1 | |||
| github.com/Otterverse/gonetworkmanager/v2 v2.2.2 | |||
There was a problem hiding this comment.
New methods were added for getting the state/reason in this fork.
| @@ -33,7 +33,7 @@ require ( | |||
| github.com/edaniels/golog v0.0.0-20230215213219-28954395e8d0 // indirect | |||
| github.com/edaniels/zeroconf v1.0.10 // indirect | |||
| github.com/goccy/go-json v0.10.2 // indirect | |||
| github.com/godbus/dbus/v5 v5.1.0 // indirect | |||
| github.com/godbus/dbus/v5 v5.1.1-0.20241109141230-b9236d654833 // indirect | |||
There was a problem hiding this comment.
This is from a pending branch that adds a feature needed for the return type of the StateReason() interface that was added.
| - uses: google-github-actions/auth@v2 | ||
| - name: Build | ||
| run: make debug-workflow all | ||
| - uses: google-github-actions/auth@v2 # This BREAKS the git checkout/tags/history, so must run after builds! |
There was a problem hiding this comment.
This drove me insane trying to find the issue here. Still don't know HOW it breaks things, but good enough for now.
ale7714
approved these changes
Feb 24, 2025
ale7714
reviewed
Feb 24, 2025
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: go.mod | ||
| - uses: google-github-actions/auth@v2 | ||
| - name: Build | ||
| run: make debug-workflow all |
There was a problem hiding this comment.
no strong opinion about but is debug-workflow intentionally here ?
There was a problem hiding this comment.
Yes, intentional while working on the eng-plan project for latest/dev release channel stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible to get a flood of near-identical errors for
scanning wifi: Scanning not allowed while unavailablewhen the wifi device wasn't in a state to allow scans.This adds additional logic to check the device state first, and skip scanning (with a quieter debug-level message) when it's in an unexpected state.
Test build: http://packages.viam.com/temp/viam-agent-v0.15.0-rc1-aarch64