fix: fn names and tests

Author: adrums86

packages/playback/src/lib/pipeline-loaders/hls-pipeline-loader.ts

@@ -13,11 +13,11 @@ interface IHlsPipelineLoaderDependencies extends IPipelineLoaderDependencies {
 export class HlsPipelineLoader implements IPipelineLoader {
   private static hlsParserFactory_: typeof ChunkPlaylistParser | null = null;
 
-  public static setHlsParser(parser: typeof ChunkPlaylistParser): void {
+  public static setHlsParserFactory(parser: typeof ChunkPlaylistParser): void {
     HlsPipelineLoader.hlsParserFactory_ = parser;
   }
 
-  public static getHlsParser(): typeof ChunkPlaylistParser | null {
+  public static getHlsParserFactory(): typeof ChunkPlaylistParser | null {
     return HlsPipelineLoader.hlsParserFactory_;
   }
 

packages/playback/src/lib/service-locator.ts

@@ -18,8 +18,6 @@ import { EventEmitter } from './utils/event-emitter';
 import { NetworkManager } from './network/network-manager';
 import { PlayerEventType } from './consts/events';
 import { PipelineLoaderFactoryStorage } from './utils/pipeline-loader-factory-storage';
-import type { ChunkPlaylistParser } from '@videojs/hls-parser';
-import { HlsPipelineLoader } from './pipeline-loaders/hls-pipeline-loader';
 
 export class ServiceLocator {
   public readonly logger: ILogger;
@@ -68,8 +66,4 @@ export class ServiceLocator {
   protected createNetworkManager_(dependencies: NetworkManagerDependencies): INetworkManager {
     return new NetworkManager(dependencies);
   }
-
-  public getHlsParser(): typeof ChunkPlaylistParser | null {
-    return HlsPipelineLoader.getHlsParser();
-  }
 }

packages/playback/test/lib/pipeline-loaders/hls-pipeline-loader.test.ts

@@ -4,10 +4,10 @@ import { ChunkPlaylistParser } from '@videojs/hls-parser';
 
 describe('hls-pipeline-loader spec', () => {
   it('parser is static pipeline loader member', () => {
-    expect(HlsPipelineLoader.getHlsParser()).toBe(null);
+    expect(HlsPipelineLoader.getHlsParserFactory()).toBe(null);
     // set parser
-    HlsPipelineLoader.setHlsParser(ChunkPlaylistParser);
-    const ChunkHlsParser = HlsPipelineLoader.getHlsParser();
+    HlsPipelineLoader.setHlsParserFactory(ChunkPlaylistParser);
+    const ChunkHlsParser = HlsPipelineLoader.getHlsParserFactory();
     expect(ChunkHlsParser).toBeTypeOf('function');
     const parser = ChunkHlsParser ? ChunkHlsParser.create({}) : null;
     expect(parser).toBeInstanceOf(ChunkPlaylistParser);

packages/playback/test/lib/service-locator.test.ts

@@ -1,7 +1,5 @@
-import { ChunkPlaylistParser } from '@videojs/hls-parser';
 import { ServiceLocator } from '../../src/lib/service-locator';
 import { beforeEach, describe, expect, it } from 'vitest';
-import { HlsPipelineLoader } from '../../src/lib/pipeline-loaders/hls-pipeline-loader';
 
 describe('Service locator spec', () => {
   let serviceLocator: ServiceLocator;
@@ -12,14 +10,4 @@ describe('Service locator spec', () => {
   it('should create a service locator instance', () => {
     expect(serviceLocator).toBeInstanceOf(ServiceLocator);
   });
-
-  it('should return the chunk hls parser', () => {
-    expect(serviceLocator.getHlsParser()).toEqual(null);
-    // set parser
-    HlsPipelineLoader.setHlsParser(ChunkPlaylistParser);
-    const ChunkHlsParser = serviceLocator.getHlsParser();
-    expect(ChunkHlsParser).toBeTypeOf('function');
-    const parser = ChunkHlsParser ? ChunkHlsParser.create({}) : null;
-    expect(parser).toBeInstanceOf(ChunkPlaylistParser);
-  });
 });