Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate new records not catching some errors for manual edits #1017

Open
Deepcuts opened this issue Mar 9, 2025 · 3 comments
Open

Validate new records not catching some errors for manual edits #1017

Deepcuts opened this issue Mar 9, 2025 · 3 comments

Comments

@Deepcuts
Copy link

Deepcuts commented Mar 9, 2025

Webmin version | 2.302
Virtualmin version | 7.30.4 Pro

I needed to edit DNS records for a domain and by mistake I wrote a , instead of .
The "Validate new records" from Virtualmin/DNS Settings/DNS Records - Manually Edit Records catched nothing.
Strange thing is "named-checkconf /etc/bind/named.conf" also reported nothing.
Because I did not see the , when I checked, I tried Webmin/Servers/Bind DNS Server - Check Bind Config, which promptly showed me the error and I was able to fix it.
Rookie mistake, but then again, my eyesight is not what it used to be.

@jcameron
Copy link
Collaborator

jcameron commented Mar 9, 2025

Can you tell us where the errant , was exactly?

Also, does the command named-checkconf -z /etc/bind/named.conf detect the error?

@Deepcuts
Copy link
Author

Deepcuts commented Mar 9, 2025

Errant , was like this:
subdomain,domain.com. IN A 1.2.3.4

named-checkconf -z /etc/bind/named.conf detects the error and shows:
/var/lib/bind/domain.com.hosts:26: subdomain,domain.com: bad owner name (check-names)

named-checkconf /etc/bind/named.conf does not detect the error.

@jcameron
Copy link
Collaborator

jcameron commented Mar 9, 2025

Ok I tested this with the command named-checkzone domain.com /var/lib/bind/domain.com.hosts and surprisingly it reported an error like that as only a warning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants