Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance]: The accept rate of typical acceptance sampling #8639

Open
1 task done
hustxiayang opened this issue Sep 19, 2024 · 0 comments
Open
1 task done

[Performance]: The accept rate of typical acceptance sampling #8639

hustxiayang opened this issue Sep 19, 2024 · 0 comments
Labels
performance Performance-related issues

Comments

@hustxiayang
Copy link

Proposal to improve performance

No response

Report of performance regression

I tested the accept length ( number of tokens per step) withtypical acceptance sampling. The accept length is even smaller than default reject sampling method.
Here is my experimental details:

  1. The dataset I used was mt_bench.
  2. Speculative decoding model's setup:
    llama3.1 8b as target model and Qwama-0.5B-Instruct as a draft model (num of speculative tokens is 2)
    llama3.1 8b as target model with MLP-speculator.
    3 Temperature was set as 0.9
    4 posterior_threshold and posterior_alpha were set as default values.

Do you have some experimental results on this? Or do I need to tune some parameters for typical acceptance sampling? Thanks a lot!

Misc discussion on performance

No response

Your current environment (if you think it is necessary)

The output of `python collect_env.py`

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@hustxiayang hustxiayang added the performance Performance-related issues label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-related issues
Projects
None yet
Development

No branches or pull requests

1 participant