Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Fix interactive refactors #244

Merged

Conversation

andrewbranch
Copy link
Contributor

Passing along this argument is required since you proxy includeInteractiveActions in getApplicableRefactors. Without this, VS Code’s “Move to File” refactor fails for all TypeScript users who have the extension installed:

Screen.Recording.2024-11-07.at.9.51.55.AM.mov

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

@volar/eslint

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/eslint@244

@volar/jsdelivr

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/jsdelivr@244

@volar/language-core

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-core@244

@volar/kit

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/kit@244

@volar/language-server

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-server@244

@volar/language-service

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-service@244

@volar/monaco

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/monaco@244

@volar/source-map

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/source-map@244

@volar/test-utils

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/test-utils@244

@volar/typescript

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/typescript@244

@volar/vscode

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/vscode@244

commit: 21946a3

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 9159efb into volarjs:master Nov 8, 2024
5 checks passed
@andrewbranch andrewbranch deleted the fix-interactive-refactors branch November 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants