feat: Sonar improvements

Author: vrnsky

chapter7/Monitor/src/main/java/file/TextSearcher.java

@@ -61,6 +61,7 @@ public class TextSearcher extends Thread {
 
     /**
      * Constructor for text searcher thread.
+     *
      * @param text    search text.
      * @param storage instance of file storage for store already checked file.
      */
@@ -72,6 +73,7 @@ public TextSearcher(final String text, final FileStorage storage) {
 
     /**
      * Return true if something was found.
+     *
      * @return true if something was found, otherwise false.
      */
     public boolean getFounded() {
@@ -98,6 +100,7 @@ public void brake() {
 
     /**
      * Return list of found files.
+     *
      * @return list of found files.
      */
     public List<String> getFileList() {
@@ -112,12 +115,13 @@ public List<String> getFileList() {
      */
     private void searchFromDisk() {
         for (File disk : disks) {
-                search(disk.getAbsolutePath());
+            search(disk.getAbsolutePath());
         }
     }
 
     /**
      * Recursive search from directory to file.
+     *
      * @param disk start of search.
      * @return true if text is find, otherwise false.
      */
@@ -128,7 +132,7 @@ private boolean search(String disk) {
                 if (file.isDirectory()) {
                     search(file.getAbsolutePath());
                 } else if (isCorrectFile(file) && !this.isInterrupted()) {
-                    processingFile(file, this.searchText);
+                    processFile(file, this.searchText);
                 }
             }
         }
@@ -137,23 +141,28 @@ private boolean search(String disk) {
 
     /**
      * Read file and set founded flag.
+     *
      * @param file for reading.
      * @param text for searching.
      */
-    private void processingFile(File file, String text) {
+    private void processFile(File file, String text) {
         this.founded = readFile(file.getAbsolutePath(), text);
-        log.info(String.format("SEARCH AT: %s", file.getAbsolutePath()));
-        if (this.founded) {
-            log.info(String.format("FOUND AT: %s", file.getAbsolutePath()));
-            synchronized (this.resultFiles) {
-                this.resultFiles.add(file.getAbsolutePath());
-            }
+        if (log.isInfoEnabled()) {
+            log.info("SEARCH AT: {}", file.getAbsolutePath());
+        }
+        if (this.founded && log.isInfoEnabled()) {
+            log.info("FOUND AT: {}", file.getAbsolutePath());
+        }
+
+        synchronized (this.resultFiles) {
+            this.resultFiles.add(file.getAbsolutePath());
         }
         this.fileStorage.addCheckedFile(file.getAbsolutePath());
     }
 
     /**
      * Read file.
+     *
      * @param file for reading.
      * @param text for searching.
      * @return true if some string in file contains text or
@@ -182,6 +191,7 @@ private boolean readFile(String file, String text) {
     /**
      * Checked that current file correct.
      * Correct means that file not read yet, not hidden and can read.
+     *
      * @param file instance of file.
      * @return true if all expression is true, otherwise false.
      */

chapter8/Parser/src/main/java/parser/Parser.java

@@ -296,9 +296,11 @@ private Vacancy parseVacancy(Element worksTopic) {
         try {
             Document worksPage = Jsoup.connect(url).get();
             String description = worksPage.getElementsByClass(MSG_BODY).select(TD_TAG).text();
-            log.info("Found vacancy: {}", worksTopic.text());
+            if (log.isInfoEnabled()) {
+                log.info("Found vacancy: {}", worksTopic.text());
+                log.info("Was published at: {}", this.getPublishDate(worksPage));
+            }
             log.info("With next desc:\n{}", description);
-            log.info("Was published at: {}", this.getPublishDate(worksPage));
             vacancy = new Vacancy(worksTopic.text(), description, this.dateParser.parseDate(getPublishDate(worksPage)), url);
         } catch (IOException | ParseException ioe) {
             log.warn(ioe.getMessage(), ioe);

chapter8/Parser/src/main/java/start/TextSimilarityChecker.java

@@ -48,7 +48,9 @@ public boolean haveSimilarVacancy(String text) {
                 String description = savedVacancies.getString("description");
                 double percentage = StringUtils.getJaroWinklerDistance(text, description) * 100;
 
-                log.info(String.format("%.2f percentage between vacancies", percentage));
+                if (log.isInfoEnabled()) {
+                    log.info(String.format("%.2f percentage between vacancies", percentage));
+                }
                 if (Double.compare(percentage, 45.0d) > 0) {
                     haveSimilar = true;
                 }

chapter9/Bank/src/main/java/model/Client.java

@@ -38,7 +38,9 @@ public Client(long timeIn, long timeOut) {
         this.checkTime(timeIn, timeOut);
         this.timeIn = timeIn;
         this.timeOut = timeOut;
-        log.info(this.toString());
+        if (log.isInfoEnabled()) {
+            log.info(this.toString());
+        }
     }
 
     /**