VRNSKY-18. Fixes from Sonar

Author: vrnsky

chapter10/Mapping/src/main/java/controllers/Adverter.java

@@ -94,7 +94,7 @@ protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws S
      */
     private void fillMapFromParsedRequest(User user, List<FileItem> items) {
         for (FileItem item : items) {
-            log.info("Processing form filed: {}", item.getFieldName());
+            log.info("Processing form field: {}", sanitizeLogInput(item.getFieldName()));
             if (log.isDebugEnabled()) {
                 String value = item.getString();
                 value = item.getFieldName().toLowerCase().contains("password") ? "*****" : sanitizeLogInput(value);

chapter9/MusicApp/src/main/java/dao/DaoAddress.java

@@ -100,7 +100,7 @@ public void prepareStatementForInsert(PreparedStatement statement, Address addre
             statement.setString(1, address.getCountry());
             statement.setString(2, address.getCity());
         } catch (SQLException e) {
-            log.error(e.getMessage(), e);
+            log.warn(e.getMessage(), e);
         }
     }
 
@@ -116,8 +116,7 @@ public void prepareStatementForUpdate(PreparedStatement statement, Address addre
             statement.setString(2, address.getCity());
             statement.setInt(3, address.getId());
         } catch (SQLException e) {
-            log.error(e.getMessage(), e);
-            throw new RuntimeException(e.getMessage(), e);
+            log.warn(e.getMessage(), e);
         }
     }
 
@@ -137,8 +136,7 @@ public List<Address> parseResultSet(ResultSet set) {
                 addresses.add(new Address(id, country, city));
             }
         } catch (SQLException sqlEx) {
-            log.error(sqlEx.getMessage(), sqlEx);
-            throw new RuntimeException(sqlEx.getMessage(), sqlEx);
+            log.warn(sqlEx.getMessage(), sqlEx);
         }
         return addresses;
     }

chapter9/MusicApp/src/main/java/dao/DaoMusicType.java

@@ -5,8 +5,8 @@
 import org.slf4j.LoggerFactory;
 
 import java.sql.PreparedStatement;
-import java.sql.SQLException;
 import java.sql.ResultSet;
+import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -38,6 +38,7 @@ private DaoMusicType() {
 
     /**
      * Return instance of this.
+     *
      * @return instance of this.
      */
     public static DaoMusicType getInstance() {
@@ -46,6 +47,7 @@ public static DaoMusicType getInstance() {
 
     /**
      * SQL query which select all from table.
+     *
      * @return SQL query for collect all order from concrete table.
      */
     @Override
@@ -55,6 +57,7 @@ public String getSelectAll() {
 
     /**
      * SQL query which select all data from one row.
+     *
      * @return SQL query for collect data from one row.
      */
     @Override
@@ -64,6 +67,7 @@ public String getSelectById() {
 
     /**
      * SQL query which edit object at the system.
+     *
      * @return SQL query which edit object in the concrete table.
      */
     @Override
@@ -73,6 +77,7 @@ public String getEdit() {
 
     /**
      * SQL query which remove order about object from concrete table.
+     *
      * @return SQL query which remove order about object at the concrete table.
      */
     @Override
@@ -82,6 +87,7 @@ public String getRemove() {
 
     /**
      * SQL query which insert data to the database.
+     *
      * @return SQL INSERT for concrete table.
      */
     @Override
@@ -91,37 +97,38 @@ public String getInsert() {
 
     /**
      * Set data to the statement.
+     *
      * @param statement instance of PreparedStatement.
-     * @param object instance of class.
+     * @param object    instance of class.
      */
     @Override
     public void prepareStatementForInsert(PreparedStatement statement, MusicType object) {
         try {
             statement.setString(1, object.getType());
         } catch (SQLException e) {
-            log.error(e.getMessage(), e);
-            throw new RuntimeException("Failed to prepare insert statement", e);
+            log.warn(e.getMessage(), e);
         }
     }
 
     /**
      * Set data to the statement.
+     *
      * @param statement instance of PreparedStatement.
-     * @param object instance of class.
+     * @param object    instance of class.
      */
     @Override
     public void prepareStatementForUpdate(PreparedStatement statement, MusicType object) {
         try {
             statement.setString(1, object.getType());
             statement.setInt(2, object.getId());
         } catch (SQLException e) {
-            log.error(e.getMessage(), e);
-            throw new RuntimeException("Failed to prepare update statement", e);
+            log.warn(e.getMessage(), e);
         }
     }
 
     /**
      * Set data to the statement.
+     *
      * @param set instance of result set interface.
      * @return list of music types.
      */
@@ -135,8 +142,7 @@ public List<MusicType> parseResultSet(ResultSet set) {
                 list.add(new MusicType(id, type));
             }
         } catch (SQLException e) {
-            log.error(e.getMessage(), e);
-            throw new RuntimeException("Failed to parse result set", e);
+            log.warn(e.getMessage(), e);
         }
 
         return list;