-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(compiler-vapor): template abbreviation of end tag #186
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaked unit test, and it failed
Size ReportBundles
Usages
|
Are you still working on this PR? |
|
related:#166
I've made some optimizations to ensure 'abbreviation' equals 'expected' through the IR, and added the 'isShouldSelfClosing' tag to the Node type. I'm not entirely sure it's correct, but it seems to work🧐