Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): correct highlighting on tag starting with template #4770

Merged
merged 3 commits into from
Aug 31, 2024
Merged

fix(vscode): correct highlighting on tag starting with template #4770

merged 3 commits into from
Aug 31, 2024

Conversation

KazariEX
Copy link
Collaborator

fix #4769

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 31, 2024 •
edited
Loading

commit: dfeafb3

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4770

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4770

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4770

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4770

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4770

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4770

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4770

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4770

Open in Stackblitz

@johnsoncodehk
Copy link
Member

Could you add a test case in https://github.com/vuejs/language-tools/tree/master/extensions/vscode/tests/grammarFixtures?

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 923f835 into vuejs:master Aug 31, 2024
5 checks passed
johnsoncodehk added a commit that referenced this pull request Aug 31, 2024
@johnsoncodehk
Revert "fix(vscode): correct highlighting on tag starting with `templ…
05a8020 
…ate` (#4770)"

This reverts commit 923f835.
@KazariEX KazariEX deleted the fix-issue-4769 branch August 31, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight error on html tag name starting with template
2 participants
@KazariEX @johnsoncodehk