Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test case Verifier 11 #14

Open
OR13 opened this issue Dec 3, 2020 · 4 comments
Open

Remove test case Verifier 11 #14

OR13 opened this issue Dec 3, 2020 · 4 comments

Comments

@OR13
Copy link
Contributor

OR13 commented Dec 3, 2020

  1. The Verifier's Verify Credential HTTP API MUST adhere to the proof verification format.

This is essentially a dupe fo the first test... it amounts to "does verification succeed".
@OR13
Copy link
Contributor Author

OR13 commented Dec 3, 2020

may also be a dupe of 13. The Verifier\'s Verify Credential HTTP API MUST support the verification of, JSON-LD Proof, Ed25519Signature2018.

@mavarley
Copy link
Contributor

Agreed it may be a dupe (not sure if it is catching a subtly or not) but does removing this req. make the test suite easier to implement? Or is it just "removing noise" from the reqs?
(just wondering why it is marked 'critical').

peacekeeper referenced this issue in peacekeeper/vc-api Jan 31, 2021
@victormartinezjurado @victormartinez-work
victormartinez/add sicpa vendor (#82)
1457705 
* add sicpa vendor

* rebase to latest master

* Strings must use singlequote

Strings must use singlequote

* Update index.js

add sicpa into vendor map

* add sicpa vendor

* rebase to latest master

* update with the latest credentials

* Update package.json

update package.json

* Update index.js

update endpoint urls

* update endpoint issue credentials

Co-authored-by: Martinez Jurado, Victor <[email protected]>
@OR13
Copy link
Contributor Author

OR13 commented Feb 1, 2021

@mavarley yes, changes to the test suite need comments! I marked them as critical before we had a release target.

@msporny msporny transferred this issue from w3c-ccg/vc-api Nov 16, 2021
@OR13
Copy link
Contributor Author

OR13 commented Nov 16, 2021

We resolved to only rely on did:key for testing, and there are a number of fixtures that should be removed, per that and related resolutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mavarley @OR13 and others